Added location button in address search #29609

huzaifa-99 · 2023-10-14T15:07:02Z

Details

This PR is a follow-up for #25855 to update the designs for the current location button. It adds the current location button to the address search dropdown along with some other UX behaviors mentioned here.

Fixed Issues

$ #25855
PROPOSAL:

Tests

Logout and Login (important) - This will clear any recent destination data
Click Fab > Request Money > Distance > Any waypoint - You will be redirected to the waypoint editor page
Click on the empty address field — verify it shows the dropdown list with only the "Use Current Location" option. Now enter some text and verify it hides the ‘Use Current Location’ option and shows relevant suggestions
Search any address and select it. This will add the address to recent destinations.
Now go back to the same waypoint editor page and clear the field value — verify it shows the "Use Current Location" option along with recent destination options.
Click on the "Use Current location" button and verify that it shows a location error below the field if location permission is denied
Click on the "Use Current location" button and verify that it shows the loader on the field and redirects after fetching the location if location permission is allowed.

Verify that no errors appear in the JS console

Offline tests

Click Fab > Request Money > Distance > Any waypoint - You will be redirected to the waypoint editor page
Click on the empty address field — verify it shows the dropdown list with only the "Use Current Location" option. Now hover the option and verify it shows a not allowed cursor and pressing the icon does nothing.

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.Native.mp4

Android: mWeb Chrome

mWeb.Chrome.mp4

iOS: Native

IOS.Native.mp4

iOS: mWeb Safari

mWeb.Safari.mp4

MacOS: Chrome / Safari

Chrome

Web.Chrome.mp4

Safari

Web.Safari.mp4

MacOS: Desktop

Desktop.Native.mp4

…urrentTargetInsideContainer

melvin-bot · 2023-10-14T15:07:06Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-14T15:07:07Z

@dannymcclain @narefyev91 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huzaifa-99 · 2023-10-14T15:09:20Z

We have a deploy blocker here that is causing Android native to crash when clicking on the request money option. For now, i applied this diff to make the test video

Diff

diff --git a/src/components/TabSelector/TabIcon.js b/src/components/TabSelector/TabIcon.js
index 85f1cd912f..b6d6e87306 100644
--- a/src/components/TabSelector/TabIcon.js
+++ b/src/components/TabSelector/TabIcon.js
@@ -26,13 +26,13 @@ const defaultProps = {
 function TabIcon({icon, activeOpacity, inactiveOpacity}) {
     return (
         <View>
-            <Animated.View style={{opacity: inactiveOpacity}}>
+            <Animated.View style={inactiveOpacity}>
                 <Icon
                     src={icon}
                     fill={themeColors.icon}
                 />
             </Animated.View>
-            <Animated.View style={[StyleSheet.absoluteFill, {opacity: activeOpacity}]}>
+            <Animated.View style={[StyleSheet.absoluteFill, activeOpacity]}>
                 <Icon
                     src={icon}
                     fill={themeColors.iconMenu}
diff --git a/src/components/TabSelector/TabLabel.js b/src/components/TabSelector/TabLabel.js
index 32c8a384d8..d67e8b0c7c 100644
--- a/src/components/TabSelector/TabLabel.js
+++ b/src/components/TabSelector/TabLabel.js
@@ -25,10 +25,10 @@ const defaultProps = {
 function TabLabel({title, activeOpacity, inactiveOpacity}) {
     return (
         <View>
-            <Animated.View style={[{opacity: activeOpacity}]}>
+            <Animated.View style={activeOpacity}>
                 <Text style={styles.tabText(true)}>{title}</Text>
             </Animated.View>
-            <Animated.View style={[StyleSheet.absoluteFill, {opacity: inactiveOpacity}]}>
+            <Animated.View style={[StyleSheet.absoluteFill, inactiveOpacity]}>
                 <Text style={styles.tabText(false)}>{title}</Text>
             </Animated.View>
         </View>

narefyev91 · 2023-10-16T13:08:53Z

src/components/AddressSearch/index.js

+                        isDisabled={props.network.isOffline}
+                    />
+                )}
+                {!props.value && <Text style={[styles.textLabel, styles.colorMuted, styles.pv2, styles.ph3, styles.overflowAuto]}>{props.translate('common.recentDestinations')}</Text>}


it can be potential crash - i will suggest to use !!props.value

Actually, this is also on the main branch

App/src/components/AddressSearch/index.js

Line 305 in 834b3d2

!props.value &&

It's for hiding header text only when the value is falsy.

Yup let's be safe here and add something like !Boolean(props.value)

@narefyev91 That change broke the linter, so I added a new commit to remove the change.

src/components/AddressSearch/isCurrentTargetInsideContainer.js

narefyev91 · 2023-10-16T13:45:21Z

Running on IOS get 1 warning and 1 error messages

Screen.Recording.2023-10-16.at.16.42.48.mov

huzaifa-99 · 2023-10-16T14:10:26Z

The console warning -> Console Warning Failed prop type: Invalid prop listLoaderComponent of type 'object' supplied to 'GooglePlacesAutocomplete' , expected 'function is also on main.

I am not able to get the console error you face, actually it shouldn't be there since its using isCurrentTargetInsideContainer.js file instead of isCurrentTargetInsideContainer.native.js. Can you please uninstall app, remove the cache(also form temp dir), and let me know if you still face the error?

rm -rf $TMPDIR/metro-cache

huzaifa-99 · 2023-10-16T14:15:28Z

Thanks for the review @narefyev91. I addressed your comments above.

narefyev91 · 2023-10-16T14:17:06Z

The console warning -> Console Warning Failed prop type: Invalid prop listLoaderComponent of type 'object' supplied to 'GooglePlacesAutocomplete' , expected 'function is also on main.

I am not able to get the console error you face, actually it shouldn't be there since its using isCurrentTargetInsideContainer.js file instead of isCurrentTargetInsideContainer.native.js. Can you please uninstall app, remove the cache(also form temp dir), and let me know if you still face the error?
rm -rf $TMPDIR/metro-cache

Yup - error is not reproduced any more.

narefyev91 · 2023-10-16T15:05:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

8mb.video-1yQ-cXVsMwA2.mp4

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

desktop1.mov

iOS

ios.mov

ios1.mov

ios2.mov

Android

android.mov

android2.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

hayata-suenaga

LGTM

OSBotify · 2023-10-17T00:47:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-17T23:57:57Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:55:27Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

huzaifa-99 added 7 commits October 13, 2023 22:10

Refactored resetDisplayListViewBorderOnBlur to be more generic -> isC…

5df247c

…urrentTargetInsideContainer

Fix dropdown list hidden visibility space

828bdc5

Added current location button to address search

1c6b610

Show location button when no recent addresses exist

dd36820

Hide textinput hint when search value length changes from 0 to 1

2b49d19

Merge branch 'main' into 25855-added-location-button-in-address-search

e327eee

Show loader on full screen when fetching current location

c992578

huzaifa-99 requested a review from a team as a code owner October 14, 2023 15:07

melvin-bot bot removed the request for review from a team October 14, 2023 15:07

melvin-bot bot requested review from dannymcclain and narefyev91 October 14, 2023 15:07

huzaifa-99 mentioned this pull request Oct 14, 2023

[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-16] 🟢 [$2000] Get user's location #25855

Closed

Use useLocalize for current location button

6d6134b

narefyev91 reviewed Oct 16, 2023

View reviewed changes

src/components/AddressSearch/isCurrentTargetInsideContainer.js Outdated Show resolved Hide resolved

huzaifa-99 added 2 commits October 16, 2023 19:13

Simplify branch case for isCurrentTargetInsideContainer

bc4f9c0

Merge branch 'main' into 25855-added-location-button-in-address-search

0d7d8c9

narefyev91 approved these changes Oct 16, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga October 16, 2023 15:05

huzaifa-99 added 2 commits October 16, 2023 20:38

Updated boolean check

bbfde5d

Updated boolean check

f5b1e62

hayata-suenaga approved these changes Oct 17, 2023

View reviewed changes

hayata-suenaga merged commit 2033be4 into Expensify:main Oct 17, 2023
15 checks passed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added location button in address search #29609

Added location button in address search #29609

huzaifa-99 commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

huzaifa-99 commented Oct 14, 2023

narefyev91 Oct 16, 2023

huzaifa-99 Oct 16, 2023

narefyev91 Oct 16, 2023

huzaifa-99 Oct 16, 2023

huzaifa-99 Oct 16, 2023

narefyev91 commented Oct 16, 2023

huzaifa-99 commented Oct 16, 2023

huzaifa-99 commented Oct 16, 2023

narefyev91 commented Oct 16, 2023

narefyev91 commented Oct 16, 2023

narefyev91 left a comment

hayata-suenaga left a comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

Added location button in address search #29609

Added location button in address search #29609

Conversation

huzaifa-99 commented Oct 14, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 14, 2023

melvin-bot bot commented Oct 14, 2023

huzaifa-99 commented Oct 14, 2023

narefyev91 Oct 16, 2023

Choose a reason for hiding this comment

huzaifa-99 Oct 16, 2023

Choose a reason for hiding this comment

narefyev91 Oct 16, 2023

Choose a reason for hiding this comment

huzaifa-99 Oct 16, 2023

Choose a reason for hiding this comment

huzaifa-99 Oct 16, 2023

Choose a reason for hiding this comment

narefyev91 commented Oct 16, 2023

huzaifa-99 commented Oct 16, 2023

huzaifa-99 commented Oct 16, 2023

narefyev91 commented Oct 16, 2023

narefyev91 commented Oct 16, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023